Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import initialize_instrument_monitor from the correct location #843

Merged
merged 8 commits into from
Dec 29, 2021

Conversation

bhilbert4
Copy link
Collaborator

This PR fixes an error seen in the cron job logs recently:

File "jwql/jwql_monitors/generate_proposal_thumbnails.py", line 34, in
from jwql.utils.utils import get_config, initialize_instrument_monitor
ImportError: cannot import name 'initialize_instrument_monitor' from 'jwql.utils.utils' (jwql/utils/utils.py)

With this fix, initialize_instrument_monitor is now imported from the correct location. Looks like this must have been missed in #804.

@bhilbert4 bhilbert4 self-assigned this Dec 20, 2021
@bhilbert4 bhilbert4 added the bug label Dec 20, 2021
@bhilbert4
Copy link
Collaborator Author

ARG. Looks like setuptools version 60 was released earlier today. I'm betting this is why RTD is failing.

@bhilbert4
Copy link
Collaborator Author

It looks to me like the mock package being installed is what is causing setuptools 60.0.1 to be installed in all cases. But version 1.0.1 of mock, which is the version being installed, is from 2012!!?

@bhilbert4
Copy link
Collaborator Author

This RTD failure looks very similar to what happened when they released version 50. It looks like RTD is installing 60.0.1, then JWQL specifies version 58, but perhaps the path to version 60 is before the path to version 58?
pypa/setuptools#2353

@bhilbert4
Copy link
Collaborator Author

Also note that jwst requires setuptools < 58.

@bhilbert4
Copy link
Collaborator Author

I suspect that this is the cause of our failing RTD builds: pypa/setuptools#2957
RTD installs the latest version of setuptools, but then JWQL (and also jwst) request older versions of setuptools.

@bourque bourque self-requested a review December 29, 2021 16:03
Copy link
Collaborator

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bhilbert4, looks good!

@bourque bourque merged commit ce69ee1 into spacetelescope:develop Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants