-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import initialize_instrument_monitor from the correct location #843
Conversation
ARG. Looks like setuptools version 60 was released earlier today. I'm betting this is why RTD is failing. |
It looks to me like the |
This RTD failure looks very similar to what happened when they released version 50. It looks like RTD is installing 60.0.1, then JWQL specifies version 58, but perhaps the path to version 60 is before the path to version 58? |
Also note that |
I suspect that this is the cause of our failing RTD builds: pypa/setuptools#2957 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhilbert4, looks good!
This PR fixes an error seen in the cron job logs recently:
File "jwql/jwql_monitors/generate_proposal_thumbnails.py", line 34, in
from jwql.utils.utils import get_config, initialize_instrument_monitor
ImportError: cannot import name 'initialize_instrument_monitor' from 'jwql.utils.utils' (jwql/utils/utils.py)
With this fix, initialize_instrument_monitor is now imported from the correct location. Looks like this must have been missed in #804.