-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a skip ci feature to the CI workflow #5591
Add a skip ci feature to the CI workflow #5591
Conversation
5fa0f1d
to
f232e1a
Compare
f5090dd
to
e4166ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #5591 +/- ##
=======================================
Coverage 74.39% 74.39%
=======================================
Files 416 416
Lines 38088 38088
Branches 5637 5637
=======================================
Hits 28336 28336
Misses 9752 9752
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
Duplicate functionality as #5577 but different approach. |
p.s. Is the addition of a file named |
Yea, that was just the change I made to show the behavior when |
I attempted to make this version a reusable action, but evidently we're not permitted to nest an action (like checkout) within another action. I think @pllim's javascript action is the way to go, though I'm in favor of setting an output and checking it with an |
Yeah, composite action isn't a thing yet though it is widely requested. You can wait, but I am not sure for how long.
Looks like there is an option to set output in https://github.com/actions/toolkit/tree/main/packages/core . But I have to think about this. Maybe I'll make it an option whether to fail or just set the output, but that also complicates the documentation and logic. |
For now though, if you can endure a red X, my action already works, as illustrated in the other PR, in case you need it immediately. |
Yeah, I don't think we want to endure red Xs for skipped CI. For Same is true for allowed failures, though that's a separate issue. The way all this worked on Travis CI was very useful and we'd like to see that identical functionality in Github actions as well. I would very much be in favor of the best of both these PRs getting put together. |
That makes sense. I am looking into it. |
I updated #5577 with your requested feature. Took me a while to get the output syntax right, but it seems to work now. |
Ok thanks a lot! Closing this one. |
Here is the issue about composite action actions/runner#646 |
This replicates the Travis feature where
[skip ci]
or[ci skip]
in the commit message causes tests to be skipped.