in aperture.plot, pass transform keyword through to fill #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mperrin LGTM! The branch you are merging, have you rebased it with the current |
mperrin
force-pushed
the
sky_transforms_2
branch
from
db2cd05
to
b81ea07
Compare
|
Rebased onto current master. Thanks for catching that! |
mfixstsci
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small followup to PR #177: The
transformkeyword argument added to theaperture.plotfunction should also be passed through to the call toax.fill. This makes thefill=Trueoption work when a transform is set.