JSOCOPS-164/165/166 #328
Merged
JSOCOPS-164/165/166 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er adding the new distortions for coron this file will need to be modified to have the corresponding secondary apertures match the primary ones
…RND master apertures
…gles for all the master apertures, for both imaging and coronagraphy
…vering the new, fixed verion
…ture definition file after matching them with the primes using the new alignment and distortions
…aperture definition file
…ly ones that matter for TA, so this is purely for consistency but without operational consequences
…c plots pertaining the apertures that have been modified in the current PR
Witchblade101
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an umbrella for updating the SIAF astrometric solution for NIRCam for both Imaging and Coronagraphy. It involves multiple changes highlighted below. Since the 3 JSOCOPS tickets 164/165/166 are interrelated, they are being combined into a single pysiaf PR and correspondingly, only a single NIRCam_SIAF.xml will be delivered to the PRD as part of PRDAPTSOC-064-002. Detailed changes:
JSOCOPS-164, using data from PID 1476, 4447 (cycle 1, 2 CAL resp.):
JSOCOPS-165, using data from PID 4447 (cycle 2 CAL):
JSOCOPS-166, using data from several GO/GTO/ERS programs:
NOTE: in all of the above cases, the new values are derived using exclusively the 2 filters F210M (for the SW channel) and F335M (for the LW channel). These are the 2 filters used for on-board TA operations, thus they are the most relevant for SIAF.