Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grating keyword to barshadow schema #260

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Feb 7, 2024

CRDS now uses GRATING for barshadow reference files.

This PR updates the barshadow schema to include the grating keyword schema.

See: https://jwst-crds.stsci.edu/browse/jwst_nirspec_barshadow_0007.rmap

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8ed8be) 64.84% compared to head (ef6717c) 64.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files         103      103           
  Lines        5694     5694           
=======================================
  Hits         3692     3692           
  Misses       2002     2002           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review February 7, 2024 17:13
@braingram braingram requested a review from a team as a code owner February 7, 2024 17:13
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro merged commit 92abfa4 into spacetelescope:main Feb 9, 2024
22 checks passed
@braingram braingram deleted the barshadow_grating branch February 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants