-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecated_properties #303
remove deprecated_properties #303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 64.84% 66.22% +1.38%
==========================================
Files 103 101 -2
Lines 5694 5403 -291
==========================================
- Hits 3692 3578 -114
+ Misses 2002 1825 -177 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine to me. Have you run a full regression test of jwst against this PR?
Thanks for taking a look! I haven't run the regtests and will update this PR when I can queue them up. |
Regression tests running at: |
Regression tests ran with only the expected failures due to system differences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
deprecated_properties
appears to have been added to allow moving "properties" within a schema:#86
However the feature seems to be unused with no schemas containing
deprecated_properties
.This PR removes the unused feature.
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)