Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated_properties #303

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 11, 2024

deprecated_properties appears to have been added to allow moving "properties" within a schema:
#86

However the feature seems to be unused with no schemas containing deprecated_properties.

This PR removes the unused feature.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.22%. Comparing base (4d7c3a6) to head (2c3f076).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   64.84%   66.22%   +1.38%     
==========================================
  Files         103      101       -2     
  Lines        5694     5403     -291     
==========================================
- Hits         3692     3578     -114     
+ Misses       2002     1825     -177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review June 12, 2024 10:00
@braingram braingram requested a review from a team as a code owner June 12, 2024 10:00
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine to me. Have you run a full regression test of jwst against this PR?

@braingram
Copy link
Collaborator Author

Code changes look fine to me. Have you run a full regression test of jwst against this PR?

Thanks for taking a look! I haven't run the regtests and will update this PR when I can queue them up.

@braingram
Copy link
Collaborator Author

braingram commented Jun 12, 2024

Regression tests running at:
https://github.com/spacetelescope/RegressionTests/actions/runs/9484628685
As this is a GA run the expected failures (due to jenkins RHEL7 issues) can be seen:
https://github.com/spacetelescope/RegressionTests/actions/runs/9457265856 (this run is just prior to the drizpars changes)

@braingram
Copy link
Collaborator Author

Regression tests ran with only the expected failures due to system differences.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hbushouse hbushouse merged commit fd5e1f4 into spacetelescope:main Jun 13, 2024
21 checks passed
@braingram braingram deleted the deprecated_properties branch June 13, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants