Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-2355: Attempt to record skip into cal_step using alias #53

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

tapastro
Copy link
Collaborator

@tapastro tapastro commented May 9, 2022

This attempts to record a skipped step into the DataModel's cal_step dictionary using the step's alias as the dict key. Need to test against jwst before any thought of merging.

Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

@nden
Copy link
Collaborator

nden commented May 9, 2022

Need to test it with romancal as well.

@tapastro
Copy link
Collaborator Author

tapastro commented May 9, 2022

Need to test it with romancal as well.

Not as familiar with that - it looks like Jenkins romancal is active, but I don't have permissions (or knowledge), while the Roman-Developers-Pull-Requests doesn't look to be fully configured. How should I go about testing this?

@nden
Copy link
Collaborator

nden commented May 9, 2022

I'm hoping @ddavis-stsci can run a test. The regression tests are not currently running successfully on Jenjins.

@tapastro
Copy link
Collaborator Author

tapastro commented May 9, 2022

jwst testing shows expected failures from (many) extra keywords now being set to 'SKIPPED' : https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/325/#showFailuresLink

@tapastro
Copy link
Collaborator Author

Has there been any update from Roman?

@ddavis-stsci
Copy link
Collaborator

Thanks for the reminder, I ran the romancal regression tests with
git+https://github.com/spacetelescope/stpipe.git@dccb314665502d939ffaf315e3f903b4348a79f
and don't see any issues.
https://plwishmaster.stsci.edu:8081/me/my-views/view/all/job/RT/job/romancal/512/

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants