-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-2355: Attempt to record skip into cal_step using alias #53
JP-2355: Attempt to record skip into cal_step using alias #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog?
Need to test it with romancal as well. |
Not as familiar with that - it looks like Jenkins romancal is active, but I don't have permissions (or knowledge), while the Roman-Developers-Pull-Requests doesn't look to be fully configured. How should I go about testing this? |
I'm hoping @ddavis-stsci can run a test. The regression tests are not currently running successfully on Jenjins. |
jwst testing shows expected failures from (many) extra keywords now being set to 'SKIPPED' : https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/325/#showFailuresLink |
Has there been any update from Roman? |
Thanks for the reminder, I ran the romancal regression tests with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This attempts to record a skipped step into the DataModel's cal_step dictionary using the step's alias as the dict key. Need to test against jwst before any thought of merging.