BUG: Fix parse_spec #103
BUG: Fix parse_spec #103
Conversation
TST: Pin synphot too in older versions job.
stsynphot/spparser.py
Outdated
| for arg in args: | ||
| try: | ||
| names.append(arg.meta['expr']) | ||
| except Exception: |
There was a problem hiding this comment.
Wouldn't be safer to look for specific types of Exception instead of the generic base type? In the way it's here, the caller wouldn't ever be able to see errors that may happen inside the try-except block. One case that we can easily spot is a KeyError from the meta['expr'] construct.
|
@ibusko , good point on the blind exception handling. I replaced it with a more explicit |
| 'rn(crcalspec$bd_75d325_stis_002.fits, band(u), 9.5, vegamag) * ' | ||
| 'band(fos, blue, 4.3, g160l)') | ||
| # NOTE: No expr for this combo. | ||
| _single_functioncall(sp1, SourceSpectrum, None, '') |
There was a problem hiding this comment.
@ibusko , as discussed in spacetelescope/synphot_refactor#237, this is the only string among those being tested that does not have a "name."
|
Re: extra tests -- I cannot think of any use case that would result in |
Fix #102
Address part of spacetelescope/synphot_refactor#237
TODO
parse_specresults and compare to doing it the non-IRAF way.