Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for NIRCam DHS sub apertures #845

Merged
merged 3 commits into from
May 17, 2024

Conversation

mperrin
Copy link
Collaborator

@mperrin mperrin commented May 12, 2024

Implements support for computing monochromatic PSFs for the NIRCam Dispersed Hartmann Sensor (DHS) mode. Intended for ETC PSF generation in support of implementing a TSO mode using the DHS.

Requires updated data files to work.

@mperrin mperrin self-assigned this May 12, 2024
@pep8speaks
Copy link

Hello @mperrin, Thank you for submitting the Pull Request !

Line 306:126: E501 line too long (148 > 125 characters)
Line 760:1: E266 too many leading '#' for block comment
Line 983:126: E501 line too long (133 > 125 characters)
Line 995:126: E501 line too long (145 > 125 characters)
Line 1014:126: E501 line too long (134 > 125 characters)
Line 1410:126: E501 line too long (200 > 125 characters)
Line 1565:126: E501 line too long (131 > 125 characters)
Line 1800:13: E731 do not assign a lambda expression, use a def
Line 1802:13: E731 do not assign a lambda expression, use a def
Line 1821:9: E266 too many leading '#' for block comment
Line 1852:9: E266 too many leading '#' for block comment
Line 1853:9: E266 too many leading '#' for block comment
Line 1915:126: E501 line too long (127 > 125 characters)
Line 2067:126: E501 line too long (141 > 125 characters)
Line 2353:126: E501 line too long (130 > 125 characters)
Line 2397:126: E501 line too long (130 > 125 characters)
Line 2407:126: E501 line too long (141 > 125 characters)
Line 2431:126: E501 line too long (130 > 125 characters)
Line 2668:23: E272 multiple spaces before keyword
Line 2783:126: E501 line too long (134 > 125 characters)

If you have not done so, please lint your code in accordance with best practices.

@mperrin mperrin added priority:high data_files JWST Affects JWST models in WebbPSF labels May 12, 2024
@mperrin mperrin requested a review from obi-wan76 May 13, 2024 19:20
@mperrin mperrin added this to the Release 1.3 milestone May 16, 2024
Copy link
Collaborator

@obi-wan76 obi-wan76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, below are some of the pupil and PSF for all the DHS apertures.
image
image
image
image
image
image

@obi-wan76 obi-wan76 merged commit 91f8f9c into spacetelescope:develop May 17, 2024
7 checks passed
@mperrin mperrin deleted the nircam_dhs0 branch May 21, 2024 15:58
mperrin added a commit to mperrin/webbpsf-st that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data_files JWST Affects JWST models in WebbPSF priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants