Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax error in .github/workflows/download_data.yml #882

Merged

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Jul 16, 2024

sorry about that!

@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Jul 16, 2024

tested this fix on my fork here: https://github.com/zacharyburnett/webbpsf/actions/runs/9961331877

it successfully downloaded the data and made a cache:
image

@zacharyburnett
Copy link
Contributor Author

Once this PR is merged you should be able to run the workflow manually to make the first cache, and then all CI will work

@mperrin mperrin merged commit 0aec204 into spacetelescope:develop Jul 16, 2024
4 of 8 checks passed
@mperrin
Copy link
Collaborator

mperrin commented Jul 16, 2024

Merged and trying the re-run of the workflow now

@zacharyburnett zacharyburnett deleted the fix/download_data_workflow branch July 16, 2024 17:37
@mperrin
Copy link
Collaborator

mperrin commented Jul 16, 2024

looks like it worked, I think?

@zacharyburnett
Copy link
Contributor Author

zacharyburnett commented Jul 16, 2024

looks like it worked, I think?

yeah it looks like it!

Cache restored from key: webbpsf-data-mini-1.3.0

https://github.com/spacetelescope/webbpsf/actions/runs/9961521680/job/27523218073#step:5:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants