Update registration module to be compatible with current scikit-image 0.18 and Python 3.9 #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se_cross_correlation instead of the deprecated skimage.feature.register_translation
…g to scikit-image==0.15.0 just to use registration module.
|
@mattcai @kevinyamauchi @neuromusic it looks like the Travis tests are failing here because the test environment is still at python=3.6, so scikit-image is 0.15, which doesn't have the |
|
@neuromusic Yes, correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As scikit-image and Python versions continue to be updated, it is no longer feasible to use scikit-image 0.15.0 to get around . This pull request will make starfish compatible with scikit-image 0.18.*
Closes #1887 and #1950
Also means PR #1946 can be closed