Update packages which need include subdirectories #10773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10769
Closes #10751(EDIT: see #10773 (comment))@HadrienG2 @davydden @jslee02 @alalazo
#10623 updated the default behavior of
.headers.directories
to exclude subdirectories (since this can cause clashes with system headers). This broke some packages which depended on the old behavior of.headers.directories
: for example if you had<package-prefix>/include/subdir/ex1.h
,.headers.directories
would include<package-prefix>/include/subdir
.This updates the
.headers
property to include subdirectories for Python and Eigen (as is recommended by these packages).In hindsight, it was a mistake not to request documentation on #10623. So that should be added here or soon.