gitlab: Add shared PR mirror to places pipelines look for binaries. #33746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
commands
core
lib/spack/spack/cmd/ci.py
Outdated
| @@ -472,6 +472,9 @@ def ci_rebuild(args): | |||
| spack.mirror.add("mirror_override", remote_mirror_override, cfg.default_modify_scope()) | |||
| pipeline_mirrors.append(remote_mirror_override) | |||
|
|
|||
| if spack_pipeline_type == "spack_pull_request": | |||
| pipeline_mirrors.append(spack_ci.SHARED_PR_MIRROR_URL) | |||
There was a problem hiding this comment.
Should this add them per-stack?
There was a problem hiding this comment.
Oh, yeah, thanks. Will fix.
While binaries built for PRs that get merged must still be rebuilt in develop pipelines, they can be used by other PRs that find they would otherwise need to rebuild them. Now that spackbot is managing copying PR binaries from merged PRs into a shared location, keeping it pruned to a reasonable size, and making sure the indices are up to date, spack can use these mirrors as a potential source of binaries.
scottwittenburg
force-pushed
the
add-shared-pr-binary-mirror
branch
from
a8b440a
to
54f2cda
Compare
kwryankrattiger
approved these changes
Nov 11, 2022
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
haampie
added a commit
to adamjstewart/spack
that referenced
this pull request
Nov 28, 2022
… for binaries. (spack#33746)" (spack#34087)" This reverts commit 63e4406.
alalazo
pushed a commit
that referenced
this pull request
Nov 28, 2022
kwryankrattiger
added a commit
that referenced
this pull request
Dec 2, 2022
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
…pack#33746) While binaries built for PRs that get merged must still be rebuilt in develop pipelines, they can be used by other PRs that find they would otherwise need to rebuild them. Now that spackbot is managing copying PR binaries from merged PRs into a shared location, keeping it pruned to a reasonable size, and making sure the indices are up to date, spack can use these mirrors as a potential source of binaries.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
…aries. (spack#33746)" (spack#34087) This reverts commit 5c4137b.
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
… for binaries. (spack#33746)" (spack#34087)" (spack#34153) This reverts commit 63e4406.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While binaries built for PRs that get merged must still be rebuilt in develop pipelines, they can be used by other PRs that find they would otherwise need to rebuild them. Now that spackbot is managing copying PR binaries from merged PRs into a shared location, keeping it pruned to a reasonable size, and making sure the indices are up to date, spack can use these mirrors as a potential source of binaries (for PR pipelines only).