Allow packages to detect presence of slingshot network #33793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
added
architecture
core
|
@tldahlgren I have already approved this PR. |
Yes, and I added you as assignee to indicate that you had done so, which allows one to quickly see which PRs have been commented on (by a non-spackbot account) or approved from the main PR list page. |
@tldahlgren Ah, okay. |
tldahlgren
reviewed
Nov 16, 2022
tldahlgren
approved these changes
Nov 16, 2022
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace the last use-case for
platform=crayconstraints that were not modeling the use of the module system. In a very few cases, the platform was being used as a proxy for the network interconnect available.@bvanessen