Python: fix bug detection, trying to access self #33955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo introduced in spack#33847
spackbot-app
bot
requested review from
adamjstewart,
pradyunsg,
scheibelp and
skosukhin
adamjstewart
approved these changes
Nov 16, 2022
|
Not really. I bet it would have been caught by pylint, but we are not ready for that yet. |
|
The error in the pipeline is unrelated. This only affects detecting Python. Force merging instead of waiting for another pipelines run. |
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
Typo introduced in spack#33847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo introduced in #33847
We cannot reference
selfin a classmethod.