Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lerc] added version 4.0.0 #33974

Merged
merged 2 commits into from
Nov 18, 2022
Merged

[lerc] added version 4.0.0 #33974

merged 2 commits into from
Nov 18, 2022

Conversation

qwertos
Copy link
Contributor

@qwertos qwertos commented Nov 17, 2022

No description provided.

@spackbot-app
Copy link

spackbot-app bot commented Nov 17, 2022

Hi @qwertos! I noticed that the following package(s) don't yet have maintainers:

  • lerc

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ["qwertos"]

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame lerc

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@qwertos
Copy link
Contributor Author

qwertos commented Nov 17, 2022

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Nov 17, 2022

Let me see if I can fix that for you!

tldahlgren
tldahlgren previously approved these changes Nov 17, 2022
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed sha256, rest LGTM.

@tldahlgren
Copy link
Contributor

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Nov 17, 2022

Let me see if I can fix that for you!

@tldahlgren
Copy link
Contributor

Oops. Suspect the PR was created without allowing maintainers to edit.

The style checks will have to be manually fixed and pushed.

@tldahlgren
Copy link
Contributor

@adamjstewart You originally appeared in the reviewer list so I'm adding you back in case you want to comment.

@tldahlgren tldahlgren self-assigned this Nov 17, 2022
@spackbot-app
Copy link

spackbot-app bot commented Nov 17, 2022

I was able to run spack style --fix for you!

spack style --fix
==> Running style checks on spack
  selected: isort, mypy, black, flake8
==> Modified files
  var/spack/repos/builtin/packages/lerc/package.py
==> Bootstrapping py-black from pre-built binaries
==> Bootstrapping py-black from pre-built binaries
==> Bootstrapping py-black %gcc target=x86_64 from sources
==> Bootstrapping clingo from pre-built binaries
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-axtxtavfahxuazw2wueu3tjwwu6ttdfo.spec.json
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.4/build_cache/linux-centos7-x86_64/gcc-10.2.1/clingo-bootstrap-spack/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-axtxtavfahxuazw2wueu3tjwwu6ttdfo.spack
==> Installing "clingo-bootstrap@spack%gcc@10.2.1~docs~ipo+python+static_libstdcpp build_type=Release arch=linux-centos7-x86_64" from a buildcache
[+] /usr/local (external python-3.7-43hsjfri6mesjgqku2qrtxnuw66pmv2w)
==> Waiting for py-pip-22.2.2-ocxfzmjgev4ornsvaqxt6ulah2vb2hr2
�[1F�[J==> Installing py-pip-22.2.2-ocxfzmjgev4ornsvaqxt6ulah2vb2hr2
==> No binary for py-pip-22.2.2-ocxfzmjgev4ornsvaqxt6ulah2vb2hr2 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py3/p/pip/pip-22.2.2-py3-none-any.whl
==> No patches needed for py-pip
==> py-pip: Executing phase: 'install'
==> py-pip: Successfully installed py-pip-22.2.2-ocxfzmjgev4ornsvaqxt6ulah2vb2hr2
  Stage: 0.84s.  Install: 3.62s.  Total: 4.52s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pip-22.2.2-ocxfzmjgev4ornsvaqxt6ulah2vb2hr2
==> Waiting for py-wheel-0.37.1-36ltt5ptghdisnd7ptooktsbx7z2ooas
�[1F�[J==> Installing py-wheel-0.37.1-36ltt5ptghdisnd7ptooktsbx7z2ooas
==> No binary for py-wheel-0.37.1-36ltt5ptghdisnd7ptooktsbx7z2ooas found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py2.py3/w/wheel/wheel-0.37.1-py2.py3-none-any.whl
==> No patches needed for py-wheel
==> py-wheel: Executing phase: 'install'
==> py-wheel: Successfully installed py-wheel-0.37.1-36ltt5ptghdisnd7ptooktsbx7z2ooas
  Stage: 0.75s.  Install: 0.86s.  Total: 1.66s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-wheel-0.37.1-36ltt5ptghdisnd7ptooktsbx7z2ooas
==> Waiting for py-setuptools-65.5.0-g3ivwsqozp44xwjzf5ykkcaiqjg3mnya
�[1F�[J==> Installing py-setuptools-65.5.0-g3ivwsqozp44xwjzf5ykkcaiqjg3mnya
==> No binary for py-setuptools-65.5.0-g3ivwsqozp44xwjzf5ykkcaiqjg3mnya found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py3/s/setuptools/setuptools-65.5.0-py3-none-any.whl
==> No patches needed for py-setuptools
==> py-setuptools: Executing phase: 'install'
==> py-setuptools: Successfully installed py-setuptools-65.5.0-g3ivwsqozp44xwjzf5ykkcaiqjg3mnya
  Stage: 0.78s.  Install: 1.49s.  Total: 2.32s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-setuptools-65.5.0-g3ivwsqozp44xwjzf5ykkcaiqjg3mnya
==> Waiting for py-flit-core-3.7.1-3cik6n2pl4ebpzgicqirqsoa57xuwuwz
�[1F�[J==> Installing py-flit-core-3.7.1-3cik6n2pl4ebpzgicqirqsoa57xuwuwz
==> No binary for py-flit-core-3.7.1-3cik6n2pl4ebpzgicqirqsoa57xuwuwz found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/f/flit-core/flit_core-3.7.1.tar.gz
==> No patches needed for py-flit-core
==> py-flit-core: Executing phase: 'install'
==> py-flit-core: Successfully installed py-flit-core-3.7.1-3cik6n2pl4ebpzgicqirqsoa57xuwuwz
  Stage: 0.77s.  Install: 1.01s.  Total: 1.85s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-flit-core-3.7.1-3cik6n2pl4ebpzgicqirqsoa57xuwuwz
==> Waiting for py-tomli-2.0.1-gthzxbnpetwknueqx4w6zr4x7yi4tqv2
�[1F�[J==> Installing py-tomli-2.0.1-gthzxbnpetwknueqx4w6zr4x7yi4tqv2
==> No binary for py-tomli-2.0.1-gthzxbnpetwknueqx4w6zr4x7yi4tqv2 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/py3/t/tomli/tomli-2.0.1-py3-none-any.whl
==> No patches needed for py-tomli
==> py-tomli: Executing phase: 'install'
==> py-tomli: Successfully installed py-tomli-2.0.1-gthzxbnpetwknueqx4w6zr4x7yi4tqv2
  Stage: 0.70s.  Install: 0.72s.  Total: 1.47s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-tomli-2.0.1-gthzxbnpetwknueqx4w6zr4x7yi4tqv2
==> Waiting for py-pathspec-0.10.1-oms4w3ojfaiscavgpp4lezciwxaotzw7
�[1F�[J==> Installing py-pathspec-0.10.1-oms4w3ojfaiscavgpp4lezciwxaotzw7
==> No binary for py-pathspec-0.10.1-oms4w3ojfaiscavgpp4lezciwxaotzw7 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/pathspec/pathspec-0.10.1.tar.gz
==> No patches needed for py-pathspec
==> py-pathspec: Executing phase: 'install'
==> py-pathspec: Successfully installed py-pathspec-0.10.1-oms4w3ojfaiscavgpp4lezciwxaotzw7
  Stage: 0.81s.  Install: 2.19s.  Total: 3.06s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pathspec-0.10.1-oms4w3ojfaiscavgpp4lezciwxaotzw7
==> Waiting for py-mypy-extensions-0.4.3-qzwwyeug33y75jxeftanhh5hxjgo4zyr
�[1F�[J==> Installing py-mypy-extensions-0.4.3-qzwwyeug33y75jxeftanhh5hxjgo4zyr
==> No binary for py-mypy-extensions-0.4.3-qzwwyeug33y75jxeftanhh5hxjgo4zyr found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/2d/2d82818f5bb3e369420cb3c4060a7970edba416647068eb4c5343488a6c604a8.tar.gz
==> No patches needed for py-mypy-extensions
==> py-mypy-extensions: Executing phase: 'install'
==> py-mypy-extensions: Successfully installed py-mypy-extensions-0.4.3-qzwwyeug33y75jxeftanhh5hxjgo4zyr
  Stage: 0.09s.  Install: 1.41s.  Total: 1.56s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-mypy-extensions-0.4.3-qzwwyeug33y75jxeftanhh5hxjgo4zyr
==> Waiting for py-typed-ast-1.5.4-27n62bfj4irltuxuyzg7i3gp5m34t22q
�[1F�[J==> Installing py-typed-ast-1.5.4-27n62bfj4irltuxuyzg7i3gp5m34t22q
==> No binary for py-typed-ast-1.5.4-27n62bfj4irltuxuyzg7i3gp5m34t22q found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/t/typed-ast/typed_ast-1.5.4.tar.gz
==> No patches needed for py-typed-ast
==> py-typed-ast: Executing phase: 'install'
==> py-typed-ast: Successfully installed py-typed-ast-1.5.4-27n62bfj4irltuxuyzg7i3gp5m34t22q
  Stage: 0.92s.  Install: 15.06s.  Total: 16.04s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-typed-ast-1.5.4-27n62bfj4irltuxuyzg7i3gp5m34t22q
==> Waiting for py-pyparsing-3.0.9-73dsrmf6xybepdechkwe56bb5aguuig5
�[1F�[J==> Installing py-pyparsing-3.0.9-73dsrmf6xybepdechkwe56bb5aguuig5
==> No binary for py-pyparsing-3.0.9-73dsrmf6xybepdechkwe56bb5aguuig5 found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/pyparsing/pyparsing-3.0.9.tar.gz
==> No patches needed for py-pyparsing
==> py-pyparsing: Executing phase: 'install'
==> py-pyparsing: Successfully installed py-pyparsing-3.0.9-73dsrmf6xybepdechkwe56bb5aguuig5
  Stage: 0.94s.  Install: 1.42s.  Total: 2.42s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-pyparsing-3.0.9-73dsrmf6xybepdechkwe56bb5aguuig5
==> Waiting for py-typing-extensions-4.3.0-xysds4jwht6prmi5oepak2bbasryrqcn
�[1F�[J==> Installing py-typing-extensions-4.3.0-xysds4jwht6prmi5oepak2bbasryrqcn
==> No binary for py-typing-extensions-4.3.0-xysds4jwht6prmi5oepak2bbasryrqcn found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/t/typing_extensions/typing_extensions-4.3.0.tar.gz
==> No patches needed for py-typing-extensions
==> py-typing-extensions: Executing phase: 'install'
==> py-typing-extensions: Successfully installed py-typing-extensions-4.3.0-xysds4jwht6prmi5oepak2bbasryrqcn
  Stage: 0.75s.  Install: 0.83s.  Total: 1.64s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-typing-extensions-4.3.0-xysds4jwht6prmi5oepak2bbasryrqcn
==> Waiting for py-packaging-21.3-orp3etzm5bl3rhtzoicrsxr3odmnmbmu
�[1F�[J==> Installing py-packaging-21.3-orp3etzm5bl3rhtzoicrsxr3odmnmbmu
==> No binary for py-packaging-21.3-orp3etzm5bl3rhtzoicrsxr3odmnmbmu found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/dd/dd47c42927d89ab911e606518907cc2d3a1f38bbd026385970643f9c5b8ecfeb.tar.gz
==> No patches needed for py-packaging
==> py-packaging: Executing phase: 'install'
==> py-packaging: Successfully installed py-packaging-21.3-orp3etzm5bl3rhtzoicrsxr3odmnmbmu
  Stage: 0.11s.  Install: 1.55s.  Total: 1.72s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-packaging-21.3-orp3etzm5bl3rhtzoicrsxr3odmnmbmu
==> Waiting for py-setuptools-scm-6.3.2-gfsolubtivxojkofipdogakfi6dbqss4
�[1F�[J==> Installing py-setuptools-scm-6.3.2-gfsolubtivxojkofipdogakfi6dbqss4
==> No binary for py-setuptools-scm-6.3.2-gfsolubtivxojkofipdogakfi6dbqss4 found: installing from source
==> Fetching https://mirror.spack.io/_source-cache/archive/a4/a49aa8081eeb3514eb9728fa5040f2eaa962d6c6f4ec9c32f6c1fba88f88a0f2.tar.gz
==> No patches needed for py-setuptools-scm
==> py-setuptools-scm: Executing phase: 'install'
==> py-setuptools-scm: Successfully installed py-setuptools-scm-6.3.2-gfsolubtivxojkofipdogakfi6dbqss4
  Stage: 0.10s.  Install: 1.54s.  Total: 1.73s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-setuptools-scm-6.3.2-gfsolubtivxojkofipdogakfi6dbqss4
==> Waiting for py-platformdirs-2.4.1-rbkbhmlzycme4e53oyxz6lvxr4ltk7na
�[1F�[J==> Installing py-platformdirs-2.4.1-rbkbhmlzycme4e53oyxz6lvxr4ltk7na
==> No binary for py-platformdirs-2.4.1-rbkbhmlzycme4e53oyxz6lvxr4ltk7na found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/p/platformdirs/platformdirs-2.4.1.tar.gz
==> No patches needed for py-platformdirs
==> py-platformdirs: Executing phase: 'install'
==> py-platformdirs: Successfully installed py-platformdirs-2.4.1-rbkbhmlzycme4e53oyxz6lvxr4ltk7na
  Stage: 0.73s.  Install: 2.13s.  Total: 2.94s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-platformdirs-2.4.1-rbkbhmlzycme4e53oyxz6lvxr4ltk7na
==> Waiting for py-zipp-3.8.1-euxyn5p6vuzvipo6pv5unlxudl2myz6p
�[1F�[J==> Installing py-zipp-3.8.1-euxyn5p6vuzvipo6pv5unlxudl2myz6p
==> No binary for py-zipp-3.8.1-euxyn5p6vuzvipo6pv5unlxudl2myz6p found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/z/zipp/zipp-3.8.1.tar.gz
==> No patches needed for py-zipp
==> py-zipp: Executing phase: 'install'
==> py-zipp: Successfully installed py-zipp-3.8.1-euxyn5p6vuzvipo6pv5unlxudl2myz6p
  Stage: 0.84s.  Install: 3.42s.  Total: 4.38s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-zipp-3.8.1-euxyn5p6vuzvipo6pv5unlxudl2myz6p
==> Waiting for py-importlib-metadata-4.12.0-bfgh2ttcs5dxlsfjznrw2vzbvmqtayfn
�[1F�[J==> Installing py-importlib-metadata-4.12.0-bfgh2ttcs5dxlsfjznrw2vzbvmqtayfn
==> No binary for py-importlib-metadata-4.12.0-bfgh2ttcs5dxlsfjznrw2vzbvmqtayfn found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/i/importlib_metadata/importlib_metadata-4.12.0.tar.gz
==> No patches needed for py-importlib-metadata
==> py-importlib-metadata: Executing phase: 'install'
==> py-importlib-metadata: Successfully installed py-importlib-metadata-4.12.0-bfgh2ttcs5dxlsfjznrw2vzbvmqtayfn
  Stage: 0.83s.  Install: 2.05s.  Total: 2.96s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-importlib-metadata-4.12.0-bfgh2ttcs5dxlsfjznrw2vzbvmqtayfn
==> Waiting for py-click-8.1.3-7cvb4sazcx4jumc3r7nwohnc2dtlkhub
�[1F�[J==> Installing py-click-8.1.3-7cvb4sazcx4jumc3r7nwohnc2dtlkhub
==> No binary for py-click-8.1.3-7cvb4sazcx4jumc3r7nwohnc2dtlkhub found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/c/click/click-8.1.3.tar.gz
==> No patches needed for py-click
==> py-click: Executing phase: 'install'
==> py-click: Successfully installed py-click-8.1.3-7cvb4sazcx4jumc3r7nwohnc2dtlkhub
  Stage: 0.77s.  Install: 1.60s.  Total: 2.45s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-click-8.1.3-7cvb4sazcx4jumc3r7nwohnc2dtlkhub
==> Waiting for py-black-22.8.0-7qzcmtcroflfqhxrys656sk4dx2vj66y
�[1F�[J==> Installing py-black-22.8.0-7qzcmtcroflfqhxrys656sk4dx2vj66y
==> No binary for py-black-22.8.0-7qzcmtcroflfqhxrys656sk4dx2vj66y found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/b/black/black-22.8.0.tar.gz
==> No patches needed for py-black
==> py-black: Executing phase: 'install'
==> py-black: Successfully installed py-black-22.8.0-7qzcmtcroflfqhxrys656sk4dx2vj66y
  Stage: 0.85s.  Install: 2.42s.  Total: 3.37s
[+] /root/.spack/bootstrap/store/linux-debian11-x86_64/gcc-10.2.1/py-black-22.8.0-7qzcmtcroflfqhxrys656sk4dx2vj66y
==> Running isort checks
  isort checks were clean
==> Running mypy checks
lib/spack/llnl/util/lang.py:1064: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/llnl/util/lock.py:84: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/util/timer.py:68: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
lib/spack/spack/bootstrap.py:87: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
Success: no issues found in 565 source files
  mypy checks were clean
==> Running black checks
reformatted var/spack/repos/builtin/packages/lerc/package.py
All done! ✨ 🍰 ✨
1 file reformatted.
  black checks were clean
==> Running flake8 checks
  flake8 checks were clean
==> spack style checks were clean
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@adamjstewart adamjstewart self-assigned this Nov 18, 2022
@adamjstewart adamjstewart merged commit 284859e into spack:develop Nov 18, 2022
@qwertos qwertos deleted the qwertos/lerc branch November 18, 2022 21:45
amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
* [lerc] added version 4.0.0

* [@spackbot] updating style on behalf of qwertos

Co-authored-by: qwertos <qwertos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants