Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-bluepyemodel: opensourcing with dependencies #40592

Merged
merged 13 commits into from
Oct 28, 2023

Conversation

heerener
Copy link
Contributor

No description provided.

@spackbot-app
Copy link

spackbot-app bot commented Oct 18, 2023

Hi @heerener! I noticed that the following package(s) don't yet have maintainers:

  • py-bluepyefe
  • py-bluepyemodel
  • py-bluepyopt
  • py-currentscape
  • py-efel
  • py-morph-tool
  • py-morphio
  • py-neurom

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers("heerener")

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame py-bluepyefe

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@tldahlgren tldahlgren changed the title py-bluepyemodel: opensourcing with dependencies py-bluepyefe: opensourcing with dependencies Oct 19, 2023
@tldahlgren tldahlgren changed the title py-bluepyefe: opensourcing with dependencies py-bluepyemodel: opensourcing with dependencies Oct 19, 2023
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all homepages, version sha256, and main branches. I could not confirm the unifurcation branch for py-morphio.

I have a question about version and branch naming.

Adding @adamjstewart since these are all python packages.

@heerener
Copy link
Contributor Author

Confirmed all homepages, version sha256, and main branches. I could not confirm the unifurcation branch for py-morphio.

I have a question about version and branch naming.

The unifurcation branch is probably an internal remnant that was overlooked; since it doesn't exist any more, I'll remove it from the recipe.
Similarly, for develop / master mismatches, I would guess it's a leftover from when these recipes were originally written for internal use without much thought put into these kinds of things. I'll try to verify that changing the version won't break anything and update.

As for the neuron-related questions: I'll check with the people who are actually familiar with the software.

var/spack/repos/builtin/packages/py-bluepyefe/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-bluepyefe/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-bluepyopt/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-morphio/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-morphio/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-neurom/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-neurom/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/py-neurom/package.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 7da4b35 into spack:develop Oct 28, 2023
13 checks passed
victoria-cherkas pushed a commit to victoria-cherkas/spack that referenced this pull request Oct 30, 2023
* py-bluepyemodel: new package with dependencies

* py-morphio: add MPI as dependency to avoid failing builds

* Formatting

* py-bluepyefe: no need to set NEURON_INIT_MPI

* py-morphio: unifurcation branch is ancient history

* py-bluepyopt: only set NEURON_INIT_MPI with +neuron

* py-efel: get rid of old version

* py-morph{-tool,io}: rename develop to master to match branch

* py-bluepyefe: unset PMI_RANK is also neuron-related

* py-bluepyopt: PMI_RANK is also neuron-related

* Implement review remarks

* py-morph-tool, py-neurom: small fixes

* py-morphio: reword dependencies
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Nov 2, 2023
* py-bluepyemodel: new package with dependencies

* py-morphio: add MPI as dependency to avoid failing builds

* Formatting

* py-bluepyefe: no need to set NEURON_INIT_MPI

* py-morphio: unifurcation branch is ancient history

* py-bluepyopt: only set NEURON_INIT_MPI with +neuron

* py-efel: get rid of old version

* py-morph{-tool,io}: rename develop to master to match branch

* py-bluepyefe: unset PMI_RANK is also neuron-related

* py-bluepyopt: PMI_RANK is also neuron-related

* Implement review remarks

* py-morph-tool, py-neurom: small fixes

* py-morphio: reword dependencies
gabrielctn pushed a commit to gabrielctn/spack that referenced this pull request Nov 24, 2023
* py-bluepyemodel: new package with dependencies

* py-morphio: add MPI as dependency to avoid failing builds

* Formatting

* py-bluepyefe: no need to set NEURON_INIT_MPI

* py-morphio: unifurcation branch is ancient history

* py-bluepyopt: only set NEURON_INIT_MPI with +neuron

* py-efel: get rid of old version

* py-morph{-tool,io}: rename develop to master to match branch

* py-bluepyefe: unset PMI_RANK is also neuron-related

* py-bluepyopt: PMI_RANK is also neuron-related

* Implement review remarks

* py-morph-tool, py-neurom: small fixes

* py-morphio: reword dependencies
mtaillefumier pushed a commit to mtaillefumier/spack that referenced this pull request Dec 14, 2023
* py-bluepyemodel: new package with dependencies

* py-morphio: add MPI as dependency to avoid failing builds

* Formatting

* py-bluepyefe: no need to set NEURON_INIT_MPI

* py-morphio: unifurcation branch is ancient history

* py-bluepyopt: only set NEURON_INIT_MPI with +neuron

* py-efel: get rid of old version

* py-morph{-tool,io}: rename develop to master to match branch

* py-bluepyefe: unset PMI_RANK is also neuron-related

* py-bluepyopt: PMI_RANK is also neuron-related

* Implement review remarks

* py-morph-tool, py-neurom: small fixes

* py-morphio: reword dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants