docs: Ecto 3 example update to better guide setups with multiple repos #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument to
:telemry.attach/4
needs to be unique otherwise it will return an error tuple saying it is already attached. I ran into this issue in an application that has multiple Ecto Repos and I didn't update the first argument to be unique. Which took me a while to track down why I was getting data for one of my repos but not the other.I figure if the example includes something that should be unique per repo name that may help others with multiple repos.
Alternatively we could include a match so it would fail the match on assignment
:ok = :telemry.attach(...
I figured the intention isn't as clear though.