Handle quit signals better #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spanezz#5, nodm will now correctly shut down instead of restarting when systemd tries to kill it
rcorre
pushed a commit
to rcorre/pkgbuilds
that referenced
this pull request
Sep 7, 2018
|
@sunweaver Any chance this will be merged to mainstream? I've been using it for a few days on multiple archlinux machines and I can now shutdown successfully. |
|
Hi,
On Mi 12 Sep 2018 14:53:05 CEST, Ryan Roden-Corrent wrote:
@sunweaver Any chance this will be merged to mainstream? I've been
using it for a few days on multiple archlinux machines and I can now
shutdown successfully.
Will do... nodm in Debian must receive another upgrade round, too. On
my list...
Greets,
Mike
--
DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
mobile: +49 (1520) 1976 148
landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
|
|
Just to make sure, will you bump the version as well after merging this? |
|
Hi |
|
@sunweaver A small bump 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5, nodm will now correctly shut down instead of restarting when systemd tries to kill it
This is a repackage of #10, which seems unlikely to ever be rebased by its author, whose GitHub activity shows that PR was their first and last (public) GitHub action.
I don't care if this is merged as-is, or used to overwrite @slashblog's branch and then merged via #10. It just seemed useful to take the rebase/squash step out of the equation and maybe get this fix landed. 😸