-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jitsi web to stable-5142 #719
Conversation
Someone recently tested this and complained of some breakage.. I wonder if that's something random that happened or if it's indeed problematic for some reason. I've got to ask just in case.. Have you actually used this and confirmed it works? |
Yes, I am using it on my server and everything seems to be working so far (Jitsi calls directly on jitsi.DOMAIN and in the widget from chat rooms too). I haven't done more extensive testing, though. |
Got it! Thanks! 👍 |
I'm curious if some additional fixes might be needed, because now configs for jitsi-web and jitsi-jvb are generated on each boot - see jitsi/docker-jitsi-meet@c149463 and jitsi/docker-jitsi-meet@0c95794. |
I didn't know that. |
I can confirm that I for one experience breakage with the new version. I have tested it a few weeks back, as I noticed the new version and intended to do a pull request myself to update it, but the image didn't work for me. So, I tested again now that it is merged in the playbook and I was hopeful that something changed, but again, jitsi doesn't function. To be more specific, I have the following configuration in my vars.yml regarding jitsi:
The breakage I experience, from most to least severe, is that:
When I have the time I will investigate to try and find the cause, but I thought I'd post the above starting clues to anyone that wants to tackle the issue in the meantime. For now, I reverted to the previous image and everything works as expected. |
I've reverted this change until we take a look at it and fix it. |
Just chiming in here to let you know that this is the same issue I encountered a few weeks back when I tried to upgrade jitsi. As commented by @teutat3s, the configs are overwritten / regenerated when the container starts. Unfortunately I won't have time to look at this for a few weeks, but I opened #729 which has my updates to the config which will be useful once this issue is resolved. |
This supersedes/fixes-up this Pull Request: #719 The Jitsi Web and JVB containers now (in build 5142) always start by bulding their own default configuration (`config.js` and `sip-communicator.properties`, respectively). The fact that we were generating these files ourselves was no longer of use, because our configuration was thrown away in favor of the one created by the containers on startup. With this commit, we're completely redoing things. We no longer generate these configuration files. We try to pass the proper environment variables, so that Jitsi services can generate the configuration files themselves. Besides that, we try to use the "custom configuration" mechanism provided by Jitsi Web and Jitsi JVB (`custom-config.js` and `custom-sip-communicator.properties`, respectively), so that we and our users can inject additional configuration. Some configuration options we had are gone now. Others are no longer controllable via variables and need to be injected using the `_config_extension` variables that we provide. The validation logic that is part of the role should take care to inform people about how to upgrade (if they're using some custom configuration, which needs special care now). Most users should not have to do anything special though.
Latest stable jitsi version is
stable-5142
.Changelog doesn't seem to indicate any breaking change.
Also worth seeing:
Changelog for this specific version: https://github.com/jitsi/jitsi-meet/releases/tag/stable%2Fjitsi-meet_5142
Full commit changelog comparing to current version (if needed): jitsi/jitsi-meet@stable/jitsi-meet_4857...stable/jitsi-meet_5142