Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jitsi web to stable-5142 #719

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

joao-p-marques
Copy link
Contributor

Latest stable jitsi version is stable-5142.

Changelog doesn't seem to indicate any breaking change.

Also worth seeing:
Changelog for this specific version: https://github.com/jitsi/jitsi-meet/releases/tag/stable%2Fjitsi-meet_5142
Full commit changelog comparing to current version (if needed): jitsi/jitsi-meet@stable/jitsi-meet_4857...stable/jitsi-meet_5142

@spantaleev
Copy link
Owner

Someone recently tested this and complained of some breakage.. I wonder if that's something random that happened or if it's indeed problematic for some reason.

I've got to ask just in case.. Have you actually used this and confirmed it works?

@joao-p-marques
Copy link
Contributor Author

Yes, I am using it on my server and everything seems to be working so far (Jitsi calls directly on jitsi.DOMAIN and in the widget from chat rooms too).

I haven't done more extensive testing, though.

@spantaleev spantaleev merged commit 32847af into spantaleev:master Nov 14, 2020
@spantaleev
Copy link
Owner

Got it! Thanks! 👍

@joao-p-marques joao-p-marques deleted the update-jitsi branch November 14, 2020 11:58
@teutat3s
Copy link
Contributor

I'm curious if some additional fixes might be needed, because now configs for jitsi-web and jitsi-jvb are generated on each boot - see jitsi/docker-jitsi-meet@c149463 and jitsi/docker-jitsi-meet@0c95794.
I have a work-in-progress branch with more changes, adjusting new env vars etc - but if this just works, then I might skip it.

@joao-p-marques
Copy link
Contributor Author

I didn't know that.
As I said, from my testing everything works, but perhaps I missed something... I don't have any custom config, so maybe that will affect others...

@ChrisKar96
Copy link
Contributor

ChrisKar96 commented Nov 18, 2020

I can confirm that I for one experience breakage with the new version. I have tested it a few weeks back, as I noticed the new version and intended to do a pull request myself to update it, but the image didn't work for me. So, I tested again now that it is merged in the playbook and I was hopeful that something changed, but again, jitsi doesn't function.

To be more specific, I have the following configuration in my vars.yml regarding jitsi:

matrix_jitsi_enabled: true
matrix_jitsi_jicofo_component_secret: GENERATED-PASS
matrix_jitsi_jicofo_auth_password: GENERATED-PASS
matrix_jitsi_jvb_auth_password: GENERATED-PASS
matrix_jitsi_jibri_recorder_password: GENERATED-PASS
matrix_jitsi_jibri_xmpp_password: GENERATED-PASS
matrix_jitsi_web_config_start_with_video_muted: true
matrix_jitsi_web_config_enableLayerSuspension: true
matrix_jitsi_web_config_channelLastN: 4
matrix_jitsi_web_interface_config_show_jitsi_watermark: false
matrix_jitsi_web_interface_config_jitsi_watermark_link: ""
matrix_jitsi_web_interface_config_show_watermark_for_guests: false
matrix_jitsi_web_interface_config_invitation_powered_by: false
matrix_jitsi_enable_transcriptions: false
matrix_jitsi_web_interface_config_disable_transcription_subtitles: true

The breakage I experience, from most to least severe, is that:

  • When a second person connects to a meeting, jitsi crashes and shows the "Something went wrong -> Reconnect" message. Reconnecting doesn't change anything
  • Even with the "start video muted: true" variable, the camera starts when entering the meeting.
  • Previews for video sources are not generated

When I have the time I will investigate to try and find the cause, but I thought I'd post the above starting clues to anyone that wants to tackle the issue in the meantime. For now, I reverted to the previous image and everything works as expected.

spantaleev added a commit that referenced this pull request Nov 18, 2020
This reverts commit 0785924
due to reports of breakage both in the support chat room
and in here #719
@spantaleev
Copy link
Owner

I've reverted this change until we take a look at it and fix it.

@cnvandijk
Copy link
Contributor

Just chiming in here to let you know that this is the same issue I encountered a few weeks back when I tried to upgrade jitsi. As commented by @teutat3s, the configs are overwritten / regenerated when the container starts. Unfortunately I won't have time to look at this for a few weeks, but I opened #729 which has my updates to the config which will be useful once this issue is resolved.

spantaleev added a commit that referenced this pull request Nov 27, 2020
This supersedes/fixes-up this Pull Request:
#719

The Jitsi Web and JVB containers now (in build 5142) always
start by bulding their own default configuration
(`config.js` and `sip-communicator.properties`, respectively).

The fact that we were generating these files ourselves was no longer of use,
because our configuration was thrown away in favor of the one created
by the containers on startup.

With this commit, we're completely redoing things. We no longer
generate these configuration files. We try to pass the proper
environment variables, so that Jitsi services can generate the
configuration files themselves.

Besides that, we try to use the "custom configuration" mechanism
provided by Jitsi Web and Jitsi JVB (`custom-config.js` and
`custom-sip-communicator.properties`, respectively), so that
we and our users can inject additional configuration.

Some configuration options we had are gone now. Others are no longer
controllable via variables and need to be injected using
the `_config_extension` variables that we provide.

The validation logic that is part of the role should take care
to inform people about how to upgrade (if they're using some custom
configuration, which needs special care now). Most users should not
have to do anything special though.
@spantaleev
Copy link
Owner

Now that commits fa76128 and b354155 have landed, our Jitsi 5142 setup should be fully working.

Well, that websocket thing in b354155 did not seem critical. Video-conferencing seems to work without it as well, but it was better to have it fixed anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants