Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/v0.2.4 #126

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Hotfix/v0.2.4 #126

merged 5 commits into from
Sep 12, 2022

Conversation

AmroAlJundi
Copy link
Contributor

A few small fixes to address the usage report done by @konstapo.

  • Commented out prints in the sparsebase::feature::Extractor and sparsebase::object::Graph classes (until verbosity is formally added to the library).
  • Made the "weighted" parameter in Matrix Market readers non-optional. This will force users to explicitly state whether the matrix market file they are reading contains weights or not. This is a temporary solution until a reader that infers this information automatically is added (effort already started in Code Suggestion for CSR to MTX File Input / Output #125).
  • Added functions to clear conversion functions from sparsebase::utils::converter::Converter classes, as well as some tests related to them.

@AmroAlJundi AmroAlJundi merged commit 645d72e into main Sep 12, 2022
@AmroAlJundi AmroAlJundi mentioned this pull request Sep 12, 2022
SinanEkm pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants