isAbsolute functions and tests are added #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add Doxygen style documentation to Is and IsAbsolute? |
AmroAlJundi
suggested changes
Nov 30, 2022
AmroAlJundi
reviewed
Nov 30, 2022
| @@ -156,10 +156,10 @@ class Format : public utils::Identifiable { | |||
| * @return true if the type of this object is T | |||
There was a problem hiding this comment.
This documentation should be for IsAbsoluate actually.
AmroAlJundi
approved these changes
Dec 1, 2022
SinanEkm
pushed a commit
that referenced
this pull request
Aug 19, 2024
isAbsolute functions and tests are added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsAbsolute and Is functions are added.
Tests for Is and IsAbsolute are added.