Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added move conversions #74

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Added move conversions #74

merged 2 commits into from
Feb 25, 2022

Conversation

AmroAlJundi
Copy link
Contributor

Added move conversion -- a utility in which converting from one format to another will reuse arrays (if possible.)

Currently, the behavior is that if converting from format A to B, then arrays that will be identical (in values) in B to what they are in A will be moved. Other arrays will not be moved.

Changes:

  • Added a second map to the Convertor class for move conversion functors.
  • Added Functors for CSR to COO and COO to CSR move conversion.
  • Modified all the functions in the Converter class to accept a boolean specifying whether or not this is a move conversion.

@AmroAlJundi AmroAlJundi linked an issue Feb 23, 2022 that may be closed by this pull request
Move converters and transformers #56
Closed
@AmroAlJundi AmroAlJundi added state: review needed type: feature Brand new functionality, features, workflows, endpoints, etc labels Feb 23, 2022
@ardasener ardasener added state: revision needed Requires additional work before next review and removed state: review needed labels Feb 24, 2022
@AmroAlJundi AmroAlJundi added state: review needed and removed state: revision needed Requires additional work before next review labels Feb 24, 2022
@ardasener ardasener added state: approved Approved to proceed. Ready to be merged and removed state: review needed labels Feb 25, 2022
@AmroAlJundi AmroAlJundi merged commit 321b089 into develop Feb 25, 2022
@AmroAlJundi AmroAlJundi deleted the feature/move_conversion branch February 25, 2022 13:31
SinanEkm pushed a commit that referenced this pull request Aug 19, 2024
@AmroAlJundi
Merge pull request #74 from SU-HPC/feature/move_conversion
daa28cf 
Added move conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardasener ardasener ardasener approved these changes

Assignees
No one assigned
Labels
state: approved Approved to proceed. Ready to be merged type: feature Brand new functionality, features, workflows, endpoints, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move converters and transformers
2 participants
@AmroAlJundi @ardasener