Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored code in terms of namespaces, file structure, and file names (and small tweaks) #92

Merged
merged 12 commits into from
Apr 5, 2022
Merged

Refactored code in terms of namespaces, file structure, and file names (and small tweaks) #92

merged 12 commits into from
Apr 5, 2022

Conversation

AmroAlJundi
Copy link
Contributor

@AmroAlJundi AmroAlJundi commented Apr 3, 2022 •
edited
Loading

Changes:

  1. Added missing namespaces.
  2. Removed sparse_ prefix from files.
  3. Refactored file structure to reflect namespaces.
  4. Changed file extension .cpp to .cc in some examples.
  5. Renamed examples' executables and folder names to match.
  6. Fixed installation instructions to work with new file system.
  7. Renamed OrderXConverter to ConverterOrderX.
  8. Fixed header guards to match Google Standard.
  9. Also added a single header to include for the entire library.
  10. Added an option for compiling examples.

@AmroAlJundi AmroAlJundi added state: review needed type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks labels Apr 3, 2022
ardasener
ardasener reviewed Apr 5, 2022
View reviewed changes
docs/pages/contributing/github_guide.md Outdated
@@ -51,24 +51,24 @@ More precisely, a typical contribution will follow this pattern:
cd sparsebase
git checkout develop
git pull origin develop
git checkout -b feature/<new_feature>
git checkout -b format/<new_feature>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of these where feature became format. I think a refactoring operation went wrong in CLion.

ardasener
ardasener suggested changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@ardasener ardasener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the small issues I commented about, library does not build on header only mode.

@AmroAlJundi AmroAlJundi merged commit b931861 into develop Apr 5, 2022
@AmroAlJundi AmroAlJundi deleted the feature/name_refactoring branch April 5, 2022 14:48
@AmroAlJundi AmroAlJundi linked an issue Apr 5, 2022 that may be closed by this pull request
Reorganizing the repo with respect to Mixins, Enum types, etc. #67
Closed
@AmroAlJundi AmroAlJundi added state: approved Approved to proceed. Ready to be merged and removed state: review needed labels Apr 5, 2022
SinanEkm pushed a commit that referenced this pull request Aug 19, 2024
@AmroAlJundi
Merge pull request #92 from SU-HPC/feature/name_refactoring
848e54e 
Refactored code in terms of namespaces, file structure, and file names (and small tweaks)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardasener ardasener ardasener approved these changes

Assignees
No one assigned
Labels
state: approved Approved to proceed. Ready to be merged type: chore Converting measurements, reorganizing folder structure, and other necessary (less impactful) tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reorganizing the repo with respect to Mixins, Enum types, etc.
2 participants
@AmroAlJundi @ardasener