Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a multi map data structure to query parameters #699

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

sansyrox
Copy link
Member

@sansyrox sansyrox commented Nov 23, 2023

Description

This PR fixes #588

Copy link

vercel bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 1:18pm

Copy link

codspeed-hq bot commented Nov 23, 2023

CodSpeed Performance Report

Merging #699 will not alter performance

Comparing fix/queries-multimap (a44617e) with main (ed4f79e)

Summary

✅ 106 untouched benchmarks

@sansyrox
Copy link
Member Author

TODO - need to add documentation of the new breaking change.

robyn/robyn.pyi Outdated
"""
pass

def get(self, key: str) -> Optional[str]:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a default argument here?

@sansyrox sansyrox merged commit 8425e7f into main Nov 25, 2023
58 of 78 checks passed
@sansyrox sansyrox deleted the fix/queries-multimap branch November 25, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request queries only outputs the last value of a query parameter
1 participant