Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zabo boards 서비스 관련 API 작업 #144

Merged
merged 29 commits into from
May 5, 2024
Merged

Zabo boards 서비스 관련 API 작업 #144

merged 29 commits into from
May 5, 2024

Conversation

jinho-choi123
Copy link
Contributor

@jinho-choi123 jinho-choi123 commented Mar 22, 2024

Summary

It closes #140

Extra info

기본적으로 session의 rolling option이 켜져있는것 같습니다. 따라서 세션 쿠키가 만료되는 문제는 걱정하지 않아도 될 것 같습니다.
(10분안에 자보 리스트 요청을 다시 보낸다는 가정 하에)

데이터베이스에 2개의 테이블을 더 만들었습니다. 하나는 디바이스의 인증 정보 및 lastSeenZabo 정보 등을 저장하고
나머지 하나는 디바이스 로그로, 어떤 디바이스에 어떤 자보가 보내졌는지를 기록합니다.

Images or Screenshots

Further Work

  • score system의 개선
  • 자보 보드에서 zabos을 모두 소진한 경우, 한 텀을 쉬었다가 다시 진행합니다(그동안 zabo fetch). 한 텀 쉬는 것을 없애는 것을 작업해야 할 것 같습니다. -> Zabo Boards 레포용 이슈

@jinho-choi123 jinho-choi123 changed the title Feature/board Zabo boards 서비스 관련 AP 작업 Mar 22, 2024
package-lock.json Outdated Show resolved Hide resolved
@jinho-choi123 jinho-choi123 changed the title Zabo boards 서비스 관련 AP 작업 Zabo boards 서비스 관련 API 작업 Mar 22, 2024
Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 고생 많으셨습니다! 감사합니다 :)
기존 코드 컨벤션에 맞게 정말 빠르게 너무 잘 작성하셔서, 금방 이해할 수 있었습니다!
몇가지 피드백을 정리해서 전달드려요.

감사합니다!!

src/admin/components/uploadZabo.jsx Show resolved Hide resolved
src/utils/statistic.js Show resolved Hide resolved
.docker/docker-compose.yml Outdated Show resolved Hide resolved
.uuid Outdated Show resolved Hide resolved
src/controllers/board.js Outdated Show resolved Hide resolved
src/controllers/board.js Show resolved Hide resolved
src/db/schema.js Show resolved Hide resolved
src/routes/board.js Outdated Show resolved Hide resolved
config/.env.example Outdated Show resolved Hide resolved
@@ -37,9 +37,11 @@
"@babel/preset-env": "^7.20.2",
"@babel/preset-react": "^7.18.6",
"@babel/register": "^7.21.0",
"@tiptap/pm": "^2.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분이 없어서 계속 yarn dev 명령에서 에러가 떴었습니다.

Copy link
Member

@withSang withSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아 보입니다! 감사합니다 👍

@withSang withSang merged commit 8568ef2 into develop May 5, 2024
@withSang withSang deleted the feature/board branch May 5, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/zabo/boards API 추가
3 participants