Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clarify pin descriptions #399

Merged
merged 2 commits into from
Sep 12, 2016

Conversation

MHassanNadeem
Copy link
Contributor

@MHassanNadeem MHassanNadeem commented May 7, 2016

  1. Fixed typos. Changed A0-A1 to A0-A5 and D0-D1 to D0-D7.
  2. Moved descriptions of alternate pin functions to appropriate locations.

@monkbroc
Copy link
Member

monkbroc commented May 7, 2016

Thanks. I'll include your suggestions shortly.

@technobly
Copy link
Member

Thanks for the contribution @Hassan-n

@monkbroc please hold off on merging this.

All changes to the datasheets should be staged here: #19

And they should be reviewed and approved by @mohitbhoite and/or me. Thanks!

@technobly technobly self-assigned this May 7, 2016
@technobly technobly mentioned this pull request May 7, 2016
@mohitbhoite mohitbhoite merged commit 4e4b77d into particle-iot:master Sep 12, 2016
technobly added a commit that referenced this pull request Sep 13, 2016
This reverts commit 4e4b77d, reversing
changes made to c000b7e.
@technobly
Copy link
Member

A bit of confusion here... essentially the changes did make it into master, but through a small re-write I did in #463 Thanks @MHassanNadeem !

@technobly technobly removed their assignment Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants