Changes to default settings and memory size computation #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused. Value is fixed at compile time.
- Make consistent with Quiic breakout - 1K = 1024
Compiler hint, can be computed at compile time.
|
Just noticed a possible side effect. The default page size is now 128 (as stated in the datasheet) instead of 64. This might break existing code, in case someone e.g. just changes the memory size for a different EEPROM and accepts the default page size. Change back to 64? |
|
PR looks good! Thanks. I agree, let's leave the default at 64. I'll fix it after merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #16.
I wasn't able to test the settings, as I don't have large size EEPROMs available. Code compiles ok und runs with 32KB EEPROM.