RV-3028-C7 Library: Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme.md, properties and license
Updated readme.md+license
Changed %02d to %02hhu to avoid possible compiler errors
This reverts commit 2ac0de5.
This reverts commit a5ce1f1.
Removed automatic clearing of RV3028_STATUS register in readRegister() RV3028::setTimer(bool timer_repeat, uint16_t timer_frequency, uint16_t timer_value, bool set_interrupt, bool start_timer); RV3028::setPeriodicUpdate(bool every_second, bool enable_interrupt, bool enable_clock_output);
Calling the constructor calls set24Hour() and disableTrickleCharge() overwriting the previous EEPROM settings without informing the caller. I've commented them out in this PR.
Added RV3028 support for Timers and PeriodicUpdate Interrupts
Added enableClockOut() and disableClockOut() functions to .cpp, prototypes to .h and updated keywords. This PR _does not_ include the hidden functions PR.
Thanks @salvagione for the useful tip. Default arguments ensure consistent behavior of the library.
Adding Clock Output (almost finished)
Update trickle charge resistor values to match datasheet.
Update trickle charge resistor values to match datasheet. This is a breaking change. If callers use previous enableTrickleCharge() values (TCR_1K, TCR_6K, TCR_11K) their code will fail to compile.
Update Trickle Charge Resistor Values
…ser-eeprom Add User EEPROM
|
Hi @bricomp , Thanks for this contribution. But we can not merge it. You are attempting to update 20 files. It is just a mess... It belongs in its own repository. Sorry! Best wishes, |
|
Perhaps you intended it to be merged here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to see if a Power on Reset has taken place and the RTC data is NOT valid.
Upon a program start it is useful to detect whether the RTC data is valid (or Not).
With the following changes this is possible.
timeUpdateRequired = readBit(RV3028_STATUS, STATUS_PORF);
In that way as soon as the RTC.begin is initiated the variable RTC.timeUpdateRequired can investigated to see if the date/time needs setting on the 3028.