Disable the keyboard shortcut for the install button for scheduled updates to avoid accidental installs. #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dates to avoid accidental installs.
|
Thank you |
zorgiepoo
added a commit
that referenced
this pull request
Mar 22, 2021
This ports #1036 over to 2.x. Looks like I forgot to port half of it.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled updates open a key window at unpredictable times. Users find that they sometimes press Enter just as the window appears, causing an interruption in their work.
Example: https://gitlab.com/gnachman/iterm2/issues/5549
This commit removes the keyboard shortcut for scheduled updates, but preserves it for user-initiated updates.