Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsteady progress when installing updates #2072

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Jan 22, 2022

We move showing installing the update after showing that the update is ready to install. We also fix progress status in dmg unarchiver not reaching 100% in some cases.

We deprecate a couple of user driver methods and replace/combine them with a method that shows installing the update and lets the driver know if the target is terminated.

Fixes #2068

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested sparkle-cli installing another app that is running or already terminated, tested an app updating itself.

macOS version tested: 12.1 (21C52)

@zorgiepoo zorgiepoo merged commit fa9bfc1 into 2.x Jan 22, 2022
@zorgiepoo zorgiepoo deleted the steady-progress branch January 22, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating progress bar not full when process complete and install button enabled
1 participant