Preserve file system compression when applying delta updates #2084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the new update has file system compression applied to its app bundle, we re-apply file system compression after applying our delta patch and before final verification.
I will add documentation update later for how to preserve file system compressions for normal updates (use
.tar.*
or.dmg
and useditto --hfsCompression
beforehand).Fixes #1194
Misc Checklist:
Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.
Testing
I tested and verified my change by using one or multiple of these methods:
Added unit tests to ensure file system compression is preserved on a large file. Tested test app with delta updates with some manual adjustments.
macOS version tested: 12.1 (21C52)