Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve file system compression when applying delta updates #2084

Merged
merged 5 commits into from
Jan 31, 2022

Conversation

zorgiepoo
Copy link
Member

If the new update has file system compression applied to its app bundle, we re-apply file system compression after applying our delta patch and before final verification.

I will add documentation update later for how to preserve file system compressions for normal updates (use .tar.* or .dmg and use ditto --hfsCompression beforehand).

Fixes #1194

Misc Checklist:

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Only bug fixes to regressions or security fixes are being backported to the 1.x (master) branch now. If you believe your change is significant enough to backport, please also create a separate pull request against the master branch.

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Added unit tests to ensure file system compression is preserved on a large file. Tested test app with delta updates with some manual adjustments.

macOS version tested: 12.1 (21C52)

@zorgiepoo zorgiepoo merged commit 94b48c4 into 2.x Jan 31, 2022
@zorgiepoo zorgiepoo deleted the delta-file-compression branch January 31, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use HFS+ compression
1 participant