Clear credential headers when redirecting to cross site #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing. #537 may fix this. |
kyoshidajp
force-pushed
the
clear_credential_headers_when_redirection
branch
from
f985cf6
to
86df950
Compare
flavorjones
force-pushed
the
clear_credential_headers_when_redirection
branch
from
86df950
to
d2e4ddb
Compare
|
I've rebased this off |
on cross-site redirection
and move all the header-modification logic to the same place in the method
flavorjones
force-pushed
the
clear_credential_headers_when_redirection
branch
from
d2e4ddb
to
250771a
Compare
|
Will be in the next release, v2.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential headers (Authorization and Cookie) are now forwarded to cross-site when redirection. Should be cleared these headers before redirection to protect leaking credential info.