Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate libxslt vulnerabilities patched in USN-4164-1 #1943

Closed
flavorjones opened this issue Nov 17, 2019 · 4 comments
Closed

Investigate libxslt vulnerabilities patched in USN-4164-1 #1943

flavorjones opened this issue Nov 17, 2019 · 4 comments

Comments

@flavorjones
Copy link
Member

@flavorjones flavorjones commented Nov 17, 2019

This issue is to drive investigation and potential action around a set of upstream patches that Canonical judged valuable enough to port to their distributions.

References:


Summary (2019-11-17)

These vulnerabilities are patched in libxslt v1.1.34 which is vendored in Nokogiri v1.10.5 and later.

Present in: Nokogiri <= v1.10.4

Advisory: upgrade to Nokogiri v1.10.5 or later


History of this notification:

  • 2019-10-22: USN-4164-1 published by Canonical
  • 2019-10-31: v1.10.5 released as a maintenance update
  • 2019-11-06: email notification to maintainer about the USN
  • 2019-11-17: this github issue created
  • 2019-11-17: analysis, advice, and security noitifcations posted
@flavorjones

This comment has been minimized.

Copy link
Member Author

@flavorjones flavorjones commented Nov 17, 2019

CVE-2019-13117

https://people.canonical.com/~ubuntu-security/cve/2019/CVE-2019-13117.html

Priority: Low

Description: In numbers.c in libxslt 1.1.33, an xsl:number with certain format strings
could lead to a uninitialized read in xsltNumberFormatInsertNumbers. This
could allow an attacker to discern whether a byte on the stack contains the
characters A, a, I, i, or 0, or any other character.

Patched with commit https://gitlab.gnome.org/GNOME/libxslt/commit/c5eb6cf3aba0af048596106ed839b4ae17ecbcb1

This patch is present in libxslt 1.1.34:

libxslt $ git tag --contains c5eb6cf3aba0af048596106ed839b4ae17ecbcb1
v1.1.34
v1.1.34-rc2
@flavorjones

This comment has been minimized.

Copy link
Member Author

@flavorjones flavorjones commented Nov 17, 2019

CVE-2019-13118

https://people.canonical.com/~ubuntu-security/cve/2019/CVE-2019-13118.html

Priority: Low

Description: In numbers.c in libxslt 1.1.33, a type holding grouping characters of an
xsl:number instruction was too narrow and an invalid character/length
combination could be passed to xsltNumberFormatDecimal, leading to a read
of uninitialized stack data

Patched with commit https://gitlab.gnome.org/GNOME/libxslt/commit/6ce8de69330783977dd14f6569419489875fb71b

This patch is present in libxslt 1.1.34:

libxslt $ git tag --contains 6ce8de69330783977dd14f6569419489875fb71b
v1.1.34
v1.1.34-rc2
@flavorjones

This comment has been minimized.

Copy link
Member Author

@flavorjones flavorjones commented Nov 17, 2019

CVE-2019-18197

https://people.canonical.com/~ubuntu-security/cve/2019/CVE-2019-18197.html

Priority: Medium

Description: In xsltCopyText in transform.c in libxslt 1.1.33, a pointer variable isn't
reset under certain circumstances. If the relevant memory area happened to
be freed and reused in a certain way, a bounds check could fail and memory
outside a buffer could be written to, or uninitialized data could be
disclosed.

Patched with commit https://gitlab.gnome.org/GNOME/libxslt/commit/2232473733b7313d67de8836ea3b29eec6e8e285

This patch is present in libxslt 1.1.34:

libxslt $ git tag --contains 2232473733b7313d67de8836ea3b29eec6e8e285
v1.1.34
v1.1.34-rc2
@flavorjones

This comment has been minimized.

Copy link
Member Author

@flavorjones flavorjones commented Nov 17, 2019

Summary

All three CVEs are patched in libxslt 1.1.34, and so these CVEs are addressed in v1.10.5 courtesy of commit 43a1753

Actions

flavorjones added a commit that referenced this issue Nov 17, 2019
related to #1943
flavorjones added a commit that referenced this issue Nov 17, 2019
related to #1943
primeos added a commit to NixOS/nixpkgs that referenced this issue Nov 17, 2019
This also updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118,
and CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943
primeos added a commit to NixOS/nixpkgs that referenced this issue Nov 17, 2019
This updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118, and
CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943
primeos added a commit to NixOS/nixpkgs that referenced this issue Nov 17, 2019
This updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118, and
CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943
primeos added a commit to primeos/nixpkgs that referenced this issue Nov 17, 2019
This also updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118,
and CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943

(cherry picked from commit 46ed8ed)
primeos added a commit to primeos/nixpkgs that referenced this issue Nov 17, 2019
This updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118, and
CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943

(cherry picked from commit ad13058)
primeos added a commit to primeos/nixpkgs that referenced this issue Nov 17, 2019
This updates Nokogiri to 1.10.5 for CVE-2019-13117, CVE-2019-13118, and
CVE-2019-18197 [0].

[0]: sparklemotion/nokogiri#1943

(cherry picked from commit 55f4feb)
va-bot added a commit to department-of-veterans-affairs/caseflow that referenced this issue Nov 18, 2019
Resolves a security warning:

```
Name: nokogiri
Version: 1.10.4
Advisory: CVE-2019-13117
Criticality: Unknown
URL: sparklemotion/nokogiri#1943
Title: Nokogiri gem, via libxslt, is affected by multiple vulnerabilities
Solution: upgrade to >= 1.10.5
```

### Description

Upgrades `nokogiri` to 1.10.5, which updates the included `libxml` dependency that contained a couple of vulnerabilities. I wouldn't expect any breakages

See: sparklemotion/nokogiri#1943
adongare added a commit to projecttacoma/cqm-parsers that referenced this issue Nov 19, 2019
roback added a commit to twingly/feedbag.herokuapp.com that referenced this issue Nov 21, 2019
roback added a commit to twingly/feedjira.herokuapp.com that referenced this issue Nov 21, 2019
selzoc added a commit to cloudfoundry/cloud_controller_ng that referenced this issue Nov 21, 2019
david-a-wheeler added a commit to coreinfrastructure/best-practices-badge that referenced this issue Nov 21, 2019
This update is due to CVE-2019-13117,
sparklemotion/nokogiri#1943
"Nokogiri gem, via libxslt, is affected by multiple vulnerabilities".

At first blush it doesn't look like these are exploitable in our
applications, but it's hard to be certain of that.
Much better to just upgrade.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
seanpdoyle added a commit to thoughtbot/administrate that referenced this issue Nov 22, 2019
```yaml
Name: nokogiri
Version: 1.10.4
Advisory: CVE-2019-13117
Criticality: Unknown
URL: sparklemotion/nokogiri#1943
Title: Nokogiri gem, via libxslt, is affected by multiple vulnerabilities
Solution: upgrade to >= 1.10.5
```
senid231 added a commit to senid231/yeti-web that referenced this issue Dec 4, 2019
Name: nokogiri
Version: 1.10.4
Advisory: CVE-2019-13117
Criticality: Unknown
URL: sparklemotion/nokogiri#1943
Title: Nokogiri gem, via libxslt, is affected by multiple vulnerabilities
Solution: upgrade to >= 1.10.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.