Add support for bare and multiple :not() functions in selectors #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for this |
|
Hope this got merged soon :) |
|
@Mange this is going to conflict with your other pull req, could you rebase your changes against the current HEAD and I'll merge this asap? Thanks |
This enables parsing of ".flash:not(.error):not(.warning)" and ":not(p)". This entailed a huge change to the parser, but I think the parser should be a bit more robust now by not declaring :not a special case.
|
Sorry for taking this long, but here's a rebased commit. All tests were passing. 🍻 |
leejarvis
added a commit
that referenced
this pull request
Jul 2, 2013
Add support for bare and multiple :not() functions in selectors
leejarvis
added a commit
that referenced
this pull request
Jul 2, 2013
|
|
|
Still not fixed. #451 (comment) |
|
This is still a thorn in my side for Capybara using Nokogiri 1.6.7.2. Can we revisit this? I'm tying myself in nots trying to get around it. |
|
I'm not sure what you mean. This PR was merged, the bugfix related was closed. If something isn't working for you, please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables parsing of
.flash:not(.error):not(.warning)and:not(p).This entailed a huge change to the parser, but I think the parser should be a bit more robust now by not declaring
:nota special case. 🎱