Skip to content

Conversation

2JS
Copy link
Contributor

@2JS 2JS commented Mar 22, 2021

In StringExtension.swift,
func removeSuffix(_ suffix: String) -> String is renamed to be consistent with
func removedPrefix(_ prefix: String) -> String

In StringExtension.swift,
`mutating func removeSuffix(_ suffix: String)` and
`func removeSuffix(_ suffix: String) -> String` are confusing, while
`mutating func removePrefix(_ prefix: String)` and
`func removedPrefix(_ prefix: String)` are properly named.
@ivanvorobei ivanvorobei merged commit 0975c10 into sparrowcode:master Mar 22, 2021
ivanvorobei added a commit that referenced this pull request Mar 27, 2022
Fix typo removeSuffix -> removedSuffix
ivanvorobei added a commit that referenced this pull request Mar 27, 2022
Fix typo removeSuffix -> removedSuffix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants