Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap subject when using the logger #1031

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

FrancisMawn
Copy link
Contributor

PR for #1022

This PR will make it so the activity logger will execute the tapActivity handler when performed on a subject that defines one.

@AlexVanderbist
Copy link
Member

Hey @FrancisMawn, thanks for the PR! Seems like an oversight indeed

@AlexVanderbist AlexVanderbist merged commit a177e7e into spatie:main Apr 7, 2022
@FrancisMawn FrancisMawn deleted the feature-tap-subject branch April 8, 2022 11:24
@seabasss
Copy link

seabasss commented Apr 9, 2022

Not sure if this PR is what made it stopped working for me, but I no longer get tap to work:

#1034

Ideas? Downgrading to the previous commit still works. Thanks!

Edit // It was this part that broke it for me...

$this->tap([$activity->subject, 'tapActivity'], $activity->event ?? '');

Would it be an idea to only apply this if you don't include a ->tap() in the activity() chain? It is currently overriding ->tap() for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants