Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not tap activities twice #1170

Closed
wants to merge 1 commit into from
Closed

Conversation

jrmajor
Copy link

@jrmajor jrmajor commented Feb 25, 2023

Fixes a bug introduced in #1031.

Copy link
Collaborator

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a fix - it removes a feature.

@jrmajor
Copy link
Author

jrmajor commented Feb 27, 2023

@Gummibeer What feature is being removed? Is it a feature that the tapActivity() method gets called twice?

@jrmajor
Copy link
Author

jrmajor commented Feb 27, 2023

// tapActivity() is called from LogsActivity (these are the lines I've removed)
if (method_exists($model, 'tapActivity')) {
    $logger->tap([$model, 'tapActivity'], $eventName);
}

// #1031 added a tapActivty() call in this method, so without
// the previous lines being removed, it will be called twice
$logger->log($description);

@krembo
Copy link

krembo commented May 24, 2023

The solution is good as tapActivity is called in log() method anyway.

@cgnathancoyne
Copy link

Hello could you expend on the feature being removed? This fix seems fine to me and tapActivity does get called inside the log()

@jrmajor jrmajor deleted the fix-tapping branch August 1, 2023 06:56
@jrmajor jrmajor restored the fix-tapping branch September 29, 2023 20:29
@chWagnr
Copy link

chWagnr commented Apr 11, 2024

@Gummibeer Is it possible to reopen the request?

tapActivity is definitly called twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants