Access model properties in ActionJob #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue identified in #76
In our QueueableAction class we could have:
public int $timeout = 240
Currently when using ActionJob we get:
PHP Warning: Attempt to read property "timeout" on string in /Users/me/dev/example-laravel/vendor/spatie/laravel-queueable-action/src/ActionJob.php on line 151
This PR fix will now return 240 whereas it previously returned the warning.
The $action variable is a string of the action ClassName, so we cannot access the $queueableProperty unless we first new up the class. Using the app() helper for this.