Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the Actions ClassName when Action called directly #82

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

ejntaylor
Copy link
Contributor

My apologies for missing this in #81

The previous PR will fix for ActionJob but break for QueuableActions called directly as they are passing the $action object as a parameter and not the class name.

There is already a check in the constructor to determine if class name or class object is passed - so we can use that to resolve this:

$this->actionClass = is_string($action) ? $action : get_class($action);

@ejntaylor ejntaylor changed the title In Addition to ActionJob PR Pass the Actions ClassName when Action called directly Aug 23, 2022
@freekmurze freekmurze merged commit 35741b4 into spatie:main Aug 23, 2022
@freekmurze
Copy link
Member

Thanks!

@ejntaylor ejntaylor deleted the fix-property-2 branch August 23, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants