Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema v10 update [🎃 hacktober] #166

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

mallardduck
Copy link
Contributor

This PR is purely a schema update patch that uses the newest Schema source that the generator can handle.
Unfortunately this is just a single version bump and the newest is v13 - so that's why #165 is laying foundation for newer data sources.

However I figured this could be created quickly and easily, so I may as well submit a PR to the current master as well. This way a release based on a slightly newer schema could be published if desired. Aside from a few additions, most changes seem to be fixes for URLs in docblocks to use HTTPS.

Copy link
Collaborator

@Gummibeer Gummibeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉
And yes, single version bumps are always preferred. As it allows people to go to the version they want/need.

@Gummibeer Gummibeer added Hacktoberfest https://hacktoberfest.digitalocean.com hacktoberfest-accepted labels Oct 5, 2021
@Gummibeer Gummibeer merged commit 5608929 into spatie:master Oct 5, 2021
@mallardduck
Copy link
Contributor Author

single version bumps are always preferred

Perfect - I will follow up with PRs for each incrementing schema version. There's going to be a lot of new tagged releases for people to get those options. 😄

@mallardduck mallardduck changed the title Schema v10 update [🎃 hacktober] Schema v10 update Oct 5, 2021
@mallardduck mallardduck changed the title [🎃 hacktober] Schema v10 update Schema v10 update [🎃 hacktober] Oct 5, 2021
@Gummibeer
Copy link
Collaborator

I will release the first one in few minutes. Only have to find time for the changelog and release. 😂

@mallardduck
Copy link
Contributor Author

Sounds good - hopefully my PR #168 helps with changelog stuff.

If you would like me to get more explicit with changes we could - but people should probably mostly refer to the SchemaOrg change-logs. 😉

@Gummibeer
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants