Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPCS sniffs #22

Closed
spaze opened this issue Aug 31, 2020 · 0 comments · Fixed by #28
Closed

Add PHPCS sniffs #22

spaze opened this issue Aug 31, 2020 · 0 comments · Fixed by #28

Comments

@spaze
Copy link
Owner

spaze commented Aug 31, 2020 •
edited
Loading

Maybe this should have a code sniffer in place.

#21 tried to add PHPCS with PSR-2 which is now deprecated but I think an up-to-date sniffs should be used in a lib targetting PHP 7.1+, like PSR-12 or Slevomat.

No code changes should be made when the sniffer is introduced, we'll need see how bad it is first :)

The author of #21 didn't want to finish what he has started so this issue is free to grab.
Repository owner deleted a comment from szepeviktor Aug 31, 2020
Repository owner deleted a comment from szepeviktor Aug 31, 2020
spaze added a commit that referenced this issue Sep 12, 2020
@spaze
PSR-12-based code sniffs plus some extra Slevomat Coding Standard rules
0955123 
Fix #22
@spaze spaze mentioned this issue Sep 12, 2020
Merged
@spaze spaze closed this as completed in #28 Sep 12, 2020
spaze added a commit that referenced this issue Sep 13, 2020
@spaze
PSR-12-based code sniffs plus some extra Slevomat Coding Standard rules
9b78c23 
Fix #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code checks spaze/phpstan-disallowed-calls
1 participant
@spaze