Updated SDFV and Corresponding HTML Template #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
changed the title
phschaad
added
bug
|
I think it also closes: spcl/dace-webclient#122 |
tbennun
approved these changes
May 30, 2024
alexnick83
pushed a commit
that referenced
this pull request
Jul 13, 2024
SDFV has been updated to include the distribution / compiled files again through a separate `dist` branch. This way pulling DaCe or installing it through pip does not require any additional builds to make use of the viewer. Additionally, paths have been corrected (the HTML template used by the `sdfv` CLI command was severely outdated). (Closes #100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDFV has been updated to include the distribution / compiled files again through a separate
distbranch. This way pulling DaCe or installing it through pip does not require any additional builds to make use of the viewer. Additionally, paths have been corrected (the HTML template used by thesdfvCLI command was severely outdated).(Closes #100)