Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issues with ABNF description #664

Closed
henkbirkholz opened this issue Apr 26, 2022 · 3 comments
Closed

Potential issues with ABNF description #664

henkbirkholz opened this issue Apr 26, 2022 · 3 comments
Milestone

Comments

@henkbirkholz
Copy link
Member

chapters/external-repository-identifiers.md does not read quite right to me. I checked with @cabo and there might be a few issues with this ABNF definition:

  • 'idstring' can start with a "-". Is that intentional? That looks curious.
  • 'compound-expression' has undefined operator precedence (wrt WITH, AND, and OR)
  • While "DocumentRef-" and "LicenseRef-" are expressed in UpperCamelCase, they are case-insensitive. Is that intentional?
    • use %s and reference RFC7405, if case-sensitive was intended
  • introduce and explain that ALPHA and DIGIT from RFC 5234
  • 'license-expression' is redundant: 'compound-expression' already includes 'simple-expression'

Additionally, the ABNF included does not really parse. Here is a proper one:

idstring = 1*(ALPHA / DIGIT / "-" / "." )

license-id = <short form license identifier in Annex A.1>

license-exception-id = <short form license exception identifier in Annex A.2>

license-ref = ["DocumentRef-" (idstring) ":"] "LicenseRef-" (idstring)

simple-expression = license-id / license-id "+" / license-ref

compound-expression = (simple-expression /
  simple-expression "WITH" license-exception-id /
  compound-expression "AND" compound-expression /
  compound-expression "OR" compound-expression /
  "(" compound-expression ")" )

license-expression = (simple-expression / compound-expression)
@zvr
Copy link
Member

zvr commented Apr 26, 2022

@henkbirkholz your link goes to #658. Is this intentional?

@zvr
Copy link
Member

zvr commented Apr 26, 2022

If this is about license expression grammar, then we should continue on #456 which was opened almost two years ago.

@kestewart
Copy link
Contributor

This was resolved in #474. If you disagree @henkbirkholz - please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants