Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support getting embed access token #17

Merged
merged 4 commits into from
Aug 25, 2022
Merged

Conversation

TristanSpeakEasy
Copy link
Member

No description provided.

@linear
Copy link

linear bot commented Aug 24, 2022

SPE-369 [SDK] Add embed-access-token grpc client to go sdk

pseudo expectation:

controller.getEmbedAccessToken([]EmbedAccessTokenFilter{}) // returns {access_token: ""}

@@ -193,3 +190,55 @@ r.Use(func (next http.Handler) http.Handler {
})
})
```

## Embedded Request Viewer Access Tokens
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexadrake I thought about the different use cases where you might want to get an access token (ie during a handler, or a method to render html output or as part of some other non handler scenario) and added a number of access patterns for it to the SDK, the Typescript SDK will also be able to support the below access patterns.

You can either get it from the controller via getting the SDK instance or using the singleton or developer created SDK instance.

As is this pattern doesn't work for the Java SDK but I was having a look and it wouldn't be too hard to refactor slightly to also support an SDK instance and provide similar access patterns. Though I think its worth a discussion on whether you think it would be worthwhile in the Java SDK

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TristanSpeakEasy and others added 3 commits August 25, 2022 09:50
Co-authored-by: anuraagnalluri <anuraagnalluri@gmail.com>
Signed-off-by: Tristan Cartledge <108070248+TristanSpeakEasy@users.noreply.github.com>
Co-authored-by: anuraagnalluri <anuraagnalluri@gmail.com>
Signed-off-by: Tristan Cartledge <108070248+TristanSpeakEasy@users.noreply.github.com>
@TristanSpeakEasy TristanSpeakEasy merged commit 05f84ea into main Aug 25, 2022
@TristanSpeakEasy TristanSpeakEasy deleted the feature/spe-369 branch August 25, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants