Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set starlette upperbound version to <0.33 #1828

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Set starlette upperbound version to <0.33 #1828

merged 1 commit into from
Dec 6, 2023

Conversation

RobbeSneyders
Copy link
Member

Temporary fix for #1826

We should release this asap.

nielsbox
nielsbox approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@nielsbox nielsbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobbeSneyders RobbeSneyders mentioned this pull request Dec 6, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 94.211%. remained the same
when pulling a2ba079 on bugfix/starlette-upperbound
into 0082d7a on main.

@RobbeSneyders RobbeSneyders merged commit dbca048 into main Dec 6, 2023
8 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/starlette-upperbound branch December 6, 2023 10:57
@RobbeSneyders
Copy link
Member Author

3.0.4 has been released containing this fix.

@nielsbox nielsbox mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsbox nielsbox nielsbox approved these changes

@Ruwann Ruwann Awaiting requested review from Ruwann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobbeSneyders @coveralls @nielsbox