Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification use raw spec on clone #1830

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Specification use raw spec on clone #1830

merged 8 commits into from
Dec 7, 2023

Conversation

nielsbox
Copy link
Collaborator

@nielsbox nielsbox commented Dec 7, 2023

Fixes #1829.

Changes proposed in this pull request:

  • Use _raw_spec when cloning

@nielsbox nielsbox marked this pull request as draft December 7, 2023 10:45
@coveralls
Copy link

coveralls commented Dec 7, 2023 •
edited

Coverage Status

coverage: 94.211%. remained the same
when pulling 1b6f3fe on bugfix/use-raw-spec-on-clone
into dbca048 on main.

@nielsbox nielsbox marked this pull request as ready for review December 7, 2023 11:01
RobbeSneyders
RobbeSneyders reviewed Dec 7, 2023
View reviewed changes
tests/api/conftest.py Outdated Show resolved Hide resolved
tests/api/test_swagger_ui.py Outdated Show resolved Hide resolved
tests/api/test_swagger_ui.py Outdated Show resolved Hide resolved
nielsbox and others added 4 commits December 7, 2023 14:07
RobbeSneyders
RobbeSneyders approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nielsbox!

@RobbeSneyders RobbeSneyders merged commit 6dc9436 into main Dec 7, 2023
8 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/use-raw-spec-on-clone branch December 7, 2023 13:54
@jdkent jdkent mentioned this pull request Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

@Ruwann Ruwann Awaiting requested review from Ruwann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connexion3 Failed to load API definition in the Swagger UI
3 participants
@nielsbox @coveralls @RobbeSneyders