-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Some hotkeys don't work on Firefox on Linux #3988
Comments
I also noticed in Firefox that sometimes after triggering an alt shortcut (like alt+o), when hitting the browser back button after triggering the alt+o shortcut, if you click alt again by itself with no other keys pressed it would re-trigger the last called alt+o shortcut. I'm also testing it on Chromium 126.0.6478.126 (Official Build) Arch Linux (64-bit) and it does the same behavior, so maybe it is a TaxonWorks bug. On Chromium all the shortcuts work except alt+d (highlights URL in location bar), alt+f (opens browser hamburger menu), and these hotkeys all seem to trigger nothing in the browser or TW: alt+l, alt+s, alt+m, alt+c, alt+shift+l. Some of the other shortcuts that do work, sometimes don't work and I'm not sure yet what causes the inconsistent behavior. Sometimes a bunch of the alt shortcuts stop working until I reload the edit nomenclature page, so it seems to be a conflict between the browser binding shortcuts and TW binding shortcuts. |
I found that you can do page-specific Firefox permissions including allowing overriding keyboard shortcuts but most of the shortcuts still don't work and still trigger the Firefox alt menus: I found an actual workaround that works. In Firefox
That fixes all hotkeys except alt+l and alt+e and this likely TW bug still exists:
|
alt+e works at the species group level. So it's just alt+l (clone taxon name) that doesn't work after disabling the Firefox alt shortcuts. |
I'm going to prevent default behavior for these events |
@gdower pushed changes for New taxon name, let me know if it works. |
@debpaul helped test this on Windows. The back button alt bug is reproducible on Windows. Almost all of the TW hotkeys work on Windows (except alt+l clone taxon name) but they also almost always also trigger opening the Firefox menus which may discourage use of the hotkeys by Windows users. Although perhaps the solution is to just document the above about:config workaround because the power users that are using hotkeys will probably be comfortable with modifying keys in about:config (unless they routinely use the Firefox alt key shortcuts to access the browser menus). |
Did she test it on local env after pull last commit? or sandbox/production? |
It was on sandbox |
I was able to replicate it on Windows using FF Development edition , but after last commit it seems to work now. |
So there's 2 hotkey bugs.
I'll test the development branch locally. |
I will check alt+l |
Awesome, you fixed the alt browser back button bug! alt+l doesn't work though. |
Steps to reproduce the bug
Possibly there is a related issue with shortcuts being bound to other functions?
Screenshot
Expected behavior
Ideally if it is possible to override the Firefox hotkeys and bind them to the TaxonWorks functions that might be ideal. At least I don't usually use those alt Firefox keyboard shortcuts. I do use ctrl Firefox shortcuts like ctrl+f, ctrl+l and ctrl+j a lot.
Additional Screenshots
No response
Environment
Sandbox
Sandbox Used
sandbox
Version
bd8bdeb
Browser Used
Arch Linux with KDE 6.1.2-1 using Firefox 127.0.2
The text was updated successfully, but these errors were encountered: