Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make current collection fetching more efficient #2770

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Make current collection fetching more efficient #2770

merged 1 commit into from
Jan 13, 2023

Conversation

maxpatiiuk
Copy link
Member

@maxpatiiuk maxpatiiuk commented Jan 10, 2023 •
edited
Loading

Turns out available collections were being fetched twice.

After this change, the collection switcher should be populated with collections as soon as the page loads.

Additional things to test:

  • Sorting
  • Switching collection
  • Collection switcher for a guest user

@maxpatiiuk maxpatiiuk requested a review from a team January 10, 2023 00:19
@grantfitzsimmons
Copy link
Member

Collection switcher for a guest user

Is this something I will need to establish in a local instance until the test panel supports actual guest users?

@maxpatiiuk
Copy link
Member Author

Yeah, sorry about that. Test panel is so neglected by us 😢

grantfitzsimmons
grantfitzsimmons approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to switch collections correctly while being an anonymous user and a logged in user. Sorting using the tool in the preferences looks to be working correctly. Everything is working as expected!

@grantfitzsimmons grantfitzsimmons merged commit 3397e74 into production Jan 13, 2023
@grantfitzsimmons grantfitzsimmons deleted the collection-fetching branch January 13, 2023 22:43
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-4-announcement/999/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxpatiiuk @grantfitzsimmons @specifysoftware