fix(healthcheck): Add a 2 second timeout to the healthchecks #1674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Addresses issue identified in #1649 (comment)
We cause the request itself to timeout if no response within 2 seconds, rather than relying on the healthcheck to timeout (this seemed to return a
-1
or127
status code). Relying on the healthcheck timeout seemed to cause docker to retry the healthcheck rather than restart the container.If the healthcheck fails for any reason, the exit code must be
1
as this is the only exit code that docker identifies as 'unhealthy'.Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References